notifications.database.common_name should not be a required field

[ljfranklin]

When enabling TLS to the DB, we were surprised to find that notifications.database.common_name was a required property. Without it the errand fails with:

ERR panic: tls: either ServerName or InsecureSkipVerify must be specified in the tls.Config  

Our expectation was that the DB client would default the server name to the hostname contained within notifications.database.url. Turns out this behavior was fixed here which was from March 2017. However the notifications app is using the go-sql-driver library from way back in 2014...

With a dependency that old I'm guessing there are other bugs present other than just the common_name behavior. Could y'all bump the go-sql-driver dependency and consider bumping any other well out of date dependencies?

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.