From 4057858cbb69cbc0cb80d62de10b2ae131cf904d Mon Sep 17 00:00:00 2001 From: Silvestre Zabala Date: Thu, 12 Sep 2024 16:31:45 +0200 Subject: [PATCH] chore(`go.work`): Remove `go.work` > It is generally inadvisable to commit go.work files into version control systems https://go.dev/ref/mod#go-work-file --- .gitignore | 4 ++-- ci/autoscaler/tasks/update-sdk/update_golang_package.sh | 3 --- go.work | 9 --------- 3 files changed, 2 insertions(+), 14 deletions(-) delete mode 100644 go.work diff --git a/.gitignore b/.gitignore index 43035b09c2..033e998c9b 100644 --- a/.gitignore +++ b/.gitignore @@ -46,8 +46,8 @@ src/acceptance/assets/app/go_app/internal/custommetrics/oas*gen.go src/acceptance/assets/app/go_app/internal/policy/oas*gen.go src/autoscaler/helpers/apis/scalinghistory/oas*gen.go -# Autogenerated files -go.work.sum +# https://go.dev/ref/mod#go-work-file +go.work* # acceptance-test binaries src/acceptance/**/*.test diff --git a/ci/autoscaler/tasks/update-sdk/update_golang_package.sh b/ci/autoscaler/tasks/update-sdk/update_golang_package.sh index 0eb0567b52..5b436a5de1 100755 --- a/ci/autoscaler/tasks/update-sdk/update_golang_package.sh +++ b/ci/autoscaler/tasks/update-sdk/update_golang_package.sh @@ -12,9 +12,6 @@ export golang_dir golang_version=$(cat "${golang_dir}/packages/golang-1-linux/version") -step "updating go.work file with golang version ${golang_version}" -go work edit -go "${golang_version}" "${autoscaler_dir}/go.work" - step "updating go.mod files with golang version ${golang_version}" find "${autoscaler_dir}" -name go.mod -type f -exec go mod edit -go "${golang_version}" "{}" \; diff --git a/go.work b/go.work deleted file mode 100644 index 1fd73397d3..0000000000 --- a/go.work +++ /dev/null @@ -1,9 +0,0 @@ -go 1.22.3 - -use ( - ./src/acceptance - ./src/acceptance/assets/app/go_app - ./src/autoscaler - ./src/changelog - ./src/changeloglockcleaner -)