Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to depend on @3 rather than pinned @3.0.0 version #144

Closed
IgorMinar opened this issue Aug 10, 2023 · 2 comments
Closed

Enable users to depend on @3 rather than pinned @3.0.0 version #144

IgorMinar opened this issue Aug 10, 2023 · 2 comments

Comments

@IgorMinar
Copy link
Contributor

Our readme.md currently instructs users to specify full version number when installing the action:

      - name: Deploy
        uses: cloudflare/[email protected]

This means that they will forever be pinned to 3.0.0. Could we instead enable users to specify the dependency as cloudflare/wrangler-action@3 as is common in npm?

I believe this will require us to maintain and overwrite the 3 tag with every minor and patch release, similarly how actions/checkout does it: https://github.com/actions/checkout/tags (they use v prefix, so see the v3 tag).

@JacobMGEvans
Copy link
Contributor

This is already possible & additionally added it to the docs https://github.com/cloudflare/wrangler-action#big-changes-in-v3

This was enabled by With these 2 PRs in for automating
This one for build & tagging for release:
#128

This one for automating the release & changelog
#132

@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Aug 10, 2023
@IgorMinar
Copy link
Contributor Author

awesome! 🎉 Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants