-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 release currently broken #137
Comments
Maybe because the action is using wrangler v3, which doesn't have a |
I should add |
Also a heads up with the new
|
ooh nice, thanks |
Previously, we prevented any error logs from propagating too far to prevent leaking of any potentially sensitive information. However, this made it difficult for developers to debug their code. In this release, we have updated our error handling to allow for more error messaging from pre/post and custom commands. We still discourage the use of these commands for secrets or other sensitive information, but we believe this change will make it easier for developers to debug their code. Relates to #137
the issue was not publish |
It will be, the release PR will be merged soon #140 |
wait, publish is an issue? |
No, @JacobMGEvans mistook your comment to mean " - command: publish --env staging
+ command: deploy --env staging not solving your problem. We were ironing out some kinks with our release process earlier, hence the confusion. We've now released v3.0.2 with improved error logging when |
Thanks for clarifying Cina! |
Ah, okay- now there is |
Yeah, only one account it added to this API token. |
Oh I think I know how you can fix this.
Should look something like this test which is part of many accounts and has a scoped API Token too: wrangler-action/.github/workflows/deploy.yml Lines 60 to 74 in 93b26a6
|
Is this a limitation of the API, does it not allow you to check the scope of a token based on accounts? This specific token can only access one account. |
btw, setting accountId does not fix the issue |
@randomairborne Could you link the GitHub Actions run with the |
It turns out I was setting it wrong, sorry. |
sounds like this has been resolved :) we will close for now, but please feel free to re-open if you are still running into issues! |
action + repo When trying to run the worker, iI get an "Error: Action Failed"
The text was updated successfully, but these errors were encountered: