-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wrangler): setup x-provision flag #7348
Conversation
🦋 Changeset detectedLatest commit: 7d4ca23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-wrangler-7348 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7348/npm-package-wrangler-7348 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-wrangler-7348 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-create-cloudflare-7348 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-kv-asset-handler-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-miniflare-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-pages-shared-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-vitest-pool-workers-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workers-editor-shared-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workers-shared-7348 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12051750545/npm-package-cloudflare-workflows-shared-7348 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
FILE_BASED_REGISTRY?: boolean; | ||
RESOURCES_PROVISION?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason to make these optional? Since it's an internal API I feel like it'd be better to keep these required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly to avoid the need to update the feature flag on every place we run an async context. If you prefer making it explicit, I can change that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/wrangler/src/index.ts
Outdated
@@ -262,6 +262,12 @@ export function createCLIParser(argv: string[]) { | |||
|
|||
return true; | |||
}) | |||
.option("experimental-provision", { | |||
describe: `Automatic resources provision`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe: `Automatic resources provision`, | |
describe: `Experimental: Enable automatic resource provisioning`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aa6c618
to
4e33617
Compare
4e33617
to
95721a4
Compare
Fixes DEVX-1422.