You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fixes the error, but then introduces new dependency issues.
The build then fails on go version 1.7 due to the missing math/bits standard library.
Updating to go 1.9 fixes the math/bits dependency but is missing bits.Add64 and bits.Mul64
Updating to go 1.12 fixes the dependency issues without breaking dep
Conclusion: updating to go 1.12 and the above patches allows the container to build and run
Should I submit a pull request with the above changes?
The text was updated successfully, but these errors were encountered:
ah so looking at the linked commit we're running tests on 1.12, but the dockerfile (which make runs) has a much older version?
bumping prometheus, and go to 1.12 sounds great, but also if migrating from dep to modules is easy go 1.17 is great too! (assuming there's not more breaking changes to stdlib)
(trying to reference the current commit)
99c99a8
It looks like prometheus has changed its dependency tree, and when I download the repo from this commit and run 'make' it fails with the above error.
updating prometheus:
and changing line 27
fixes the error, but then introduces new dependency issues.
The build then fails on go version 1.7 due to the missing
math/bits
standard library.Updating to go 1.9 fixes the math/bits dependency but is missing
bits.Add64
andbits.Mul64
Updating to go 1.12 fixes the dependency issues without breaking dep
Conclusion: updating to go 1.12 and the above patches allows the container to build and run
Should I submit a pull request with the above changes?
The text was updated successfully, but these errors were encountered: