Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallVec with length 1 #1746

Open
larseggert opened this issue Mar 20, 2024 · 0 comments
Open

SmallVec with length 1 #1746

larseggert opened this issue Mar 20, 2024 · 0 comments

Comments

@larseggert
Copy link

pub frames: Option<SmallVec<[QuicFrame; 1]>>,

This allocates a SmallVec that spills on the heap when the second element is inserted, which is probably much earlier than you want. Suggest bumping this up to 8 or 16 or something (whatever number you think a good bound for the number of frames in most QUIC packets is.)

You might also want to review other uses of SmallVec in quiche.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant