Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Output Source Selection #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Output Source Selection #25

wants to merge 1 commit into from

Conversation

tekno-on-git
Copy link

Add the option to select the audio output device in the dialog.

Changelog

Closes #19

Added AudioOutputSelector in the SettingsDialog

Screenshots

Before:

image

After:

image

@renandincer
Copy link
Member

thank you for the PR @kxzazz!

@third774 third774 self-requested a review April 9, 2024 16:11
@third774
Copy link
Collaborator

third774 commented Apr 9, 2024

Thanks for the contribution, @kxzazz! I think we've got some other non-trivial work to do in order to make this work reliably (for instance, when an audio output device is disconnected), so I'm going to hold off on merging this PR for now. Once we've got the other pieces in place, we can use this to add the UI though!

@tekno-on-git
Copy link
Author

Thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@third774 third774 Awaiting requested review from third774

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output source selection
3 participants
@tekno-on-git @renandincer @third774