-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 2024.10.0 appears to have broken xterm.js (e.g. Proxmox WebUI) when served over CF tunnel #1337
Comments
I confirm. On my OpenWRT router I have Cloudflare version: 2024.4.1-2 and it causes the above problem |
Confirmed that, at least in my case, the issue only began after |
I can also confirm. I did not run into this issue until upgrading to 2024.10.0 recently. |
I confirm this issue as well. |
I think it is probably this commit: e2064c8#diff-6ff9dc179d3cf0539f514218792ce1d93001e2b4835a695bde442ad45edf01deR516 @chungthuang It looks like it used to be that if it is not a websocket (false), then Now it is checking if I suspect this has wider implications on websockets more broadly beyond Proxmox. I think it would be worth adding a websocket to the tests too. At the moment the tests in that commit only covers HTTP so things like this could get missed in the current test coverage. |
Could someone try this PR out to confirm if it fixes the issue? Clone it, run |
@maggie44 I'll try this out later |
I bisected the issue (#1340 (comment)) and found the breaking commit to be e2064c8 |
ISSUE #1337 🔥 🤑 |
Haha yes I also noticed this 🤣 Note there is now a fix for this ready to land hopefully soon |
Hey everyone! Thank you for letting us know of this problem and for the effort in identifying the cause of the issue. We decided to fully revert the change and will take some time to evaluate a better approach. Please let us know if you still see this issue after upgrading to 2024.10.1. |
Can confirm things are working as expected in 2024.10.1 |
@GoncaloGarcia In spite of reverting the change, installing the new version it really feels like the interface is less reliable than previous. While the console loads, it frequently disconnects and I have to refresh the page. Do you think this could still be related to other changes in Reopening the issue for the time being for visibility |
Fixed in the latest version 2024.10.1 |
@itsthejb what do you mean by interface? Proxmox interface? The code in 2024.10.0 had very minimal changes and the only one that could affect traffic was the one we reverted. so it should not be related. |
@joliveirinha Yes, it's not the original issue, which is definitely fixed. I just noticed the web console stalling and losing the connection but differently. I could indeed be some different, so I just wanted to ask in case you thought there might be something else. Sure, I'll leave the issue closed. I suspect it is something else, just wanted to ask why the topic is still warm. Cheers |
can confirm that with 2024.10.1 the issue is not present anymore. |
Describe the bug
Prior to
2024.10.0
it was possible to serve Proxmox web UI over a CF tunnel. However since2024.10.0
the defaultxterm.js
CT/VM web console is failing withConnection failed (Error 501: )
. ThenoVNC
implementation continues to work without issues.To Reproduce
Steps to reproduce the behavior:
2024.10.0
>_ Shell
buttonConnection failed (Error 501: )
Expected behavior
2024.10.0
Environment and versions
2024.10.0
Logs and errors
journalctl
forcloudflared
when the failure happensAdditional context
Would like to test a downgrade toVerified that the issue was introduced after2024.9.1
to verify the problem exactly, but not sure how this is possible2024.9.1
by restoring to a backup w/2024.9.1
, where everything works as beforecloudflared
installed w/apt
in a Debian Bookworm LXCThe text was updated successfully, but these errors were encountered: