-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue parsing Image Details from API due to incorrect struct json field #1379
Conversation
changelog detected ✅ |
Codecov Report
@@ Coverage Diff @@
## master #1379 +/- ##
========================================
Coverage 48.33% 48.34%
========================================
Files 133 139 +6
Lines 13023 13749 +726
========================================
+ Hits 6295 6647 +352
- Misses 5201 5453 +252
- Partials 1527 1649 +122
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR! added some notes inline.
This functionality has been released in v0.76.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Issue is described here: #1378
API returns the metadata object under the field
meta
. However the SDK expects the fieldmetadata
thus it always drops this data from the response.Has your change been tested?
Yes - after changing the struct field for Metadata to
meta
,GetImage
calls return images with Metadata field populated.Screenshots (if appropriate):
https://developers.cloudflare.com/api/operations/cloudflare-images-image-details
Refer to the response example of Image details. Specifically the
meta
field. The current SDK expectsmetadata
and thus it always drops the metadata from the response.Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.