-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Zone Hold functionality #1365
Conversation
changelog detected ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR!
i've left some feedback inline about the library conventions we need to update here but we'll also need to add test coverage. you can check out another file like https://github.com/cloudflare/cloudflare-go/blob/master/accounts_test.go to get an idea on the minimums we expect here.
Co-authored-by: Jacob Bednarz <[email protected]>
Signed-off-by: Jacob Bednarz <[email protected]>
…ures Signed-off-by: Jacob Bednarz <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
+ Coverage 48.33% 48.49% +0.15%
==========================================
Files 133 138 +5
Lines 13023 13413 +390
==========================================
+ Hits 6295 6504 +209
- Misses 5201 5322 +121
- Partials 1527 1587 +60
|
The response body is identical to other zone hold responses so let's reuse that instead. Signed-off-by: Jacob Bednarz <[email protected]>
This functionality has been released in v0.75.0. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Adds the ability to create a zone hold based on the hold API.
Has your change been tested?
I called the apis manually. I am happy to write tests, but I'm not sure where to get started. I could stub the responses, but since this is basically just calling the raw api, im not sure what I would be testing (no additional logic).
Screenshots (if appropriate):
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.
closes #1364