Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub releases #226

Closed
dentarg opened this issue Jan 26, 2021 · 7 comments · Fixed by #241
Closed

Use GitHub releases #226

dentarg opened this issue Jan 26, 2021 · 7 comments · Fixed by #241

Comments

@dentarg
Copy link
Member

dentarg commented Jan 26, 2021

We can use https://github.com/marketplace/actions/create-a-release

Upside: "Releases" are more prominent displayed in the GitHub UI (e.g. in the side bar on the repo front page https://github.com/cloudamqp/avalanchemq)

Originally posted by @carlhoerberg in #219 (comment)

@carlhoerberg
Copy link
Member

Or delete all existing releases? And then the github repos main page will just says "123 tags", instead of showing an old release.

@dentarg
Copy link
Member Author

dentarg commented Jan 27, 2021

We could, but I think we should embrace releases :) We are embracing issues and discussions, so using releases makes sense to me!

@carlhoerberg
Copy link
Member

I don't get how to use the annotated tag message as body for the release, and others seems to have the same problem too: actions/create-release#118

@carlhoerberg
Copy link
Member

And git show doesn't respect the --format flag when the ref is a tag some some reason

@carlhoerberg
Copy link
Member

but maybe git show -s v1.0.0-alpha.25 | tail -n+6 could work

carlhoerberg added a commit that referenced this issue Feb 10, 2021
Creates a GH release, but in draft mode because the current action can't
get the git tag message as body.

Closes #226
@dentarg
Copy link
Member Author

dentarg commented Feb 10, 2021

@carlhoerberg what about git tag -l -n99 v1.0.0-alpha.25?

$ git tag -l -n99 v1.0.0-alpha.25
v1.0.0-alpha.25 1.0.0-alpha.25

    - Deleted queues could reappear after a crash
    - Never send frames to closed channels
    - Checking RSS on OS X could fail when FD limit was reached
    - Escaping connection name in UI to prevent XSS
    - Crystal 0.36.0 compability
    - Don't open a temp write for every channel, only when needed

Found it in https://stackoverflow.com/questions/5358336/how-to-list-all-tags-along-with-the-full-message-in-git

@dentarg
Copy link
Member Author

dentarg commented Feb 10, 2021

Could also do (I'm sure there's a clever way to remove the PGP block)

$ git tag --list --format="%(body)" v1.0.0-alpha.25
- Deleted queues could reappear after a crash
- Never send frames to closed channels
- Checking RSS on OS X could fail when FD limit was reached
- Escaping connection name in UI to prevent XSS
- Crystal 0.36.0 compability
- Don't open a temp write for every channel, only when needed
-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEMzD4srPR52lwwLOiPeQ7a6E9BckFAmAVeyUACgkQPeQ7a6E9
BckjoA//YSm1LUI9DbxLo2qcjLPqz1P+HAIsIdsCoEmH4jH0Qui16ydT/XMZ9fZZ
O5/5SGewOmQgI/m1IOvtXvRyhpWwaxMB35tbiY7zFOXZCvuuG3YatIWFMvhGZ4h6
dgdgHiFXC4QRbNqRKEN5wVep+prCN0vfnBAFJVpEcH8rWAb+lZO/yyK2QrsW/HDJ
wo4Zch1P4Ya6S/s5NG8+QbQifTkkaVeTRjPU6ovrrlJ2GIQYd35Mzd7/2MoZEIaF
Y5MwnWuc0Nt5uBWmBZWAUqb2OH98KeY77uOSg2awhK0p1MztQ6d85AGhwgTARsGi
paxhICUsfzyyDhxdfQaUossydKHrxrPyjQwffRdNeW50GIDjO2s3I2UU6z0WsUgz
lMi6CA2GJbW3kAq3RV0JhI2SSnpNxcy+yR9NFUDfzOuqrSAWOCUHt8augqu2Oly+
Kg0XAX4c4B8BkGgIpX64+uELGusM3ESQ93BSMy/4rV7A5kPbzMHbtY6qpTh7XRTn
dWtTACQraoPLJ/JneS52i+JNoS0+Akpi/MkGrEDIlzD9orshZhpmKFnTXk6rIUve
jNWUSZ58OTr5UAXWHUkZVhxfN+kfm530yvVtJEC9AfiLQ4n4QmoFWRfpB6o7K1gC
YVQIvY5nPQszbOAGgNNtpDTsoC1HOuvCI1lY6vomY6N1CYnxGwA=
=9rTq
-----END PGP SIGNATURE-----

dentarg pushed a commit that referenced this issue May 7, 2021
Creates a GH release, but in draft mode because the current action can't
get the git tag message as body.

Closes #226
dentarg added a commit that referenced this issue May 7, 2021
Uses the annotated tag body as part of release notes.

Also adds a diff link against the previous version to the release notes.

Closes #226

Co-authored-by: Patrik Ragnarsson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants