Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Attendee email and name are the same (both are email) #111

Open
FeralFlora opened this issue Feb 19, 2024 · 4 comments
Open

[BUG]: Attendee email and name are the same (both are email) #111

FeralFlora opened this issue Feb 19, 2024 · 4 comments

Comments

@FeralFlora
Copy link

Not sure if this should be labelled a bug or a feature request. But in any case, the issue is that name and email are both the email of the attendee. This is a) redundant and b) a loss of information, since the actual name is not available. I'm trying to implement the workflow requested here (formatting the name as a link to the person folder), but without the name, it's not possible. Unless perhaps if you add the email as an alias to the note, but that's something you can only do after the note has been created, in this scenario.

So I'm wondering if this is intentional, which it seems to be based on this and this, and if so, why? Is it because the name of the attendee is simply not available? If so, bummer.

@muness
Copy link
Member

muness commented Feb 19, 2024

Hi @FeralFlora - I noticed the same and it may be worth adding a note or alternative handling to

obsidian-ics/src/main.ts

Lines 104 to 120 in dad4fc2

let guests: IGuest[] = [];
if (e.attendee) {
if (Array.isArray(e.attendee)) {
guests = e.attendee.map(att => {
return {
name: att.params.CN,
email: att.val.substring(7), // Remove 'mailto:' prefix
status: att.params.PARTSTAT
};
});
} else {
guests.push({
name: e.attendee.params.CN,
email: e.attendee.val.substring(7), // Remove 'mailto:' prefix
status: e.attendee.params.PARTSTAT
});
}

I downloaded several ics files from different providers and CN (canonical name) is often the email address instead of the name. I don't know why this is the case. It is not always email, sometimes coming through as the attendee's name.

I'd rather not manipulate the data as it comes through, so could see adding another field or two with processed name & email if you think that is what most people expect.

@muness
Copy link
Member

muness commented Feb 19, 2024

For reference: https://www.kanzaki.com/docs/ical/attendee.html

@FeralFlora
Copy link
Author

FeralFlora commented Feb 19, 2024

For reference: https://www.kanzaki.com/docs/ical/attendee.html

Thanks for the link:

The property parameter CN is for the common or displayable name associated with the calendar address

Strange how yours and my experience doesn't line up with this ☝️

I'd rather not manipulate the data as it comes through, so could see adding another field or two with processed name & email if you think that is what most people expect.

I understand, that makes sense. If something like that is possible, it would be great, but what would you process, if CN is just the email?

@FeralFlora
Copy link
Author

I've shared my current attendee implementation here: #74 (reply in thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants