Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include test templates in sdist tarball #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Natureshadow
Copy link

Please include these templates and release a new (post) release to PyPI.

This is important to be able to reproducibly run the test suite in the Debian package.

@clokep clokep self-requested a review October 1, 2021 16:47
@clokep
Copy link
Owner

clokep commented Oct 19, 2021

While testing this I ended up with the tests directory installed into site-packages, which is generally unwanted.

This seems to match what Django has in their MANIFEST.in, but I don't seem to end up with their tests in site-packages -- maybe there's a missing config somewhere to control that?

@clokep clokep removed their request for review October 19, 2021 12:19
@ghost
Copy link

ghost commented Nov 15, 2022

I tried to rebase this branch on top of main and ran pyproject-build .. It correctly includes the tests folder in the sdist and not in the wheel.

@clokep clokep self-requested a review November 15, 2022 20:23
@clokep
Copy link
Owner

clokep commented Jun 28, 2024

While testing this I ended up with the tests directory installed into site-packages, which is generally unwanted.

Do you have any response to this? Is there updated guidance saying this is a good idea?

@clokep clokep removed their request for review June 28, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants