Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How necessary is PersistentProtocolBufferMap, really? #21

Open
oubiwann opened this issue Dec 25, 2017 · 1 comment
Open

How necessary is PersistentProtocolBufferMap, really? #21

oubiwann opened this issue Dec 25, 2017 · 1 comment
Labels
exploration

Comments

@oubiwann
Copy link
Member

I guess this is going to end up as part of #16, but it kinda deserves a ticket of its own.

Can we provide the naming strategies in straight-up Clojure? Efficiently? Can we ditch this?
@oubiwann
Copy link
Member Author

I suspect one of the primary reasons for using the Java class initially was to easily get map-like behaviour (semantics as well as rendering in the REPL) in the protobuf class. With the new style of ProtoBufAPI implementations in the project now, we've got that in Clojure with gen-class ... maybe we can work towards ditching PersistentProtocolBufferMap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exploration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oubiwann