TS Refactor #61
Open
TS Refactor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed start values for _targetX and _targetY
|
This package seems no longer maintained. I would just fork this code and release it yourself |
karlafalcao
approved these changes
Mar 6, 2024
|
@karlafalcao it has been a while since I made this PR, so I made other improvements in a separate fork. Take a look at this repo https://github.com/halvardssm/virtual-assistant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! It was amazing to find a working package for the good 'ol Clippy.
This PR contains a complete refactor of the codebase to TypeScript. It removes all usage of jquery and external dependencies and uses lazy loading for fetching agents.
Changelog:
There is only one part missing, and that is to fix the bundling, but this is underway in a separate PR to Parcel.
Any feedback is appreciated!