Convert all warnings to errors

clickbar · Sep 25, 2024 · 56e9f75 · 56e9f75
1 parent 3d98bdb
commit 56e9f75
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 18 deletions.
diff --git a/.changeset/sharp-dancers-build.md b/.changeset/sharp-dancers-build.md
@@ -0,0 +1,7 @@
+---
+'@clickbar/eslint-config-typescript': patch
+'@clickbar/eslint-config-base': patch
+'@clickbar/eslint-config-vue': patch
+---
+
+Convert all warnings to errors
diff --git a/packages/base/index.js b/packages/base/index.js
@@ -82,7 +82,7 @@ export default function base() {
         sourceType: 'module',
       },
       linterOptions: {
-        reportUnusedDisableDirectives: 'warn',
+        reportUnusedDisableDirectives: 'error',
       },
       plugins: {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
@@ -94,8 +94,8 @@ export default function base() {
         'import-x/internal-regex': '^(@/)', // allow imports beginning with @/
       },
       rules: {
-        'tailwindcss/enforces-negative-arbitrary-values': 'warn',
-        'tailwindcss/enforces-shorthand': 'warn',
+        'tailwindcss/enforces-negative-arbitrary-values': 'error',
+        'tailwindcss/enforces-shorthand': 'error',
         'tailwindcss/no-contradicting-classname': 'error',
 
         'import-x/order': [
@@ -122,7 +122,7 @@ export default function base() {
 
         'unused-imports/no-unused-imports': 'error',
         'unused-imports/no-unused-vars': [
-          'warn',
+          'error',
           {
             vars: 'all',
             varsIgnorePattern: '^_',
@@ -149,8 +149,8 @@ export default function base() {
         'unicorn/no-nested-ternary': 'off',
         'unicorn/number-literal-case': 'off',
 
-        'no-console': ['warn', { allow: ['warn', 'error'] }],
-        'no-debugger': 'warn',
+        'no-console': ['error', { allow: ['warn', 'error'] }],
+        'no-debugger': 'error',
         'no-var': 'error',
         'object-shorthand': ['error', 'always'],
         'prefer-const': 'error',

diff --git a/packages/typescript/index.js b/packages/typescript/index.js
@@ -45,11 +45,11 @@ export default function typescript() {
         '@typescript-eslint/consistent-type-definitions': 'off',
 
         // Adjust levels
-        '@typescript-eslint/no-unsafe-argument': 'warn',
-        '@typescript-eslint/no-unsafe-call': 'warn',
-        '@typescript-eslint/no-unsafe-member-access': 'warn',
-        '@typescript-eslint/no-unsafe-return': 'warn',
-        '@typescript-eslint/unified-signatures': 'warn',
+        '@typescript-eslint/no-unsafe-argument': 'error',
+        '@typescript-eslint/no-unsafe-call': 'error',
+        '@typescript-eslint/no-unsafe-member-access': 'error',
+        '@typescript-eslint/no-unsafe-return': 'error',
+        '@typescript-eslint/unified-signatures': 'error',
       },
     },
     {

diff --git a/packages/vue/index.js b/packages/vue/index.js
@@ -117,7 +117,7 @@ export default function vue() {
           ['script-setup'], // 'script-setup', 'composition', 'composition-vue2', or 'options'
         ],
         'vue/component-name-in-template-casing': [
-          'warn',
+          'error',
           'PascalCase',
           { registeredComponentsOnly: false },
         ],
@@ -143,9 +143,9 @@ export default function vue() {
         ],
         'vue/define-props-declaration': 'error',
         'vue/html-button-has-type': 'error',
-        'vue/html-comment-content-newline': 'warn',
-        'vue/html-comment-content-spacing': 'warn',
-        'vue/html-comment-indent': 'warn',
+        'vue/html-comment-content-newline': 'error',
+        'vue/html-comment-content-spacing': 'error',
+        'vue/html-comment-indent': 'error',
         'vue/html-self-closing': [
           'error',
           {
@@ -159,10 +159,10 @@ export default function vue() {
           },
         ],
         'vue/next-tick-style': ['error', 'promise'],
-        'vue/no-duplicate-attr-inheritance': 'warn',
+        'vue/no-duplicate-attr-inheritance': 'error',
         'vue/no-empty-component-block': 'error',
         'vue/no-multiple-objects-in-class': 'error',
-        'vue/no-ref-object-reactivity-loss': 'warn',
+        'vue/no-ref-object-reactivity-loss': 'error',
         'vue/no-required-prop-with-default': 'error',
         'vue/no-restricted-call-after-await': 'error',
         'vue/no-root-v-if': 'error',
@@ -175,7 +175,7 @@ export default function vue() {
           [{ blankLine: 'always', prev: '*', next: '*' }],
         ],
         'vue/prefer-define-options': 'error',
-        'vue/prefer-import-from-vue': 'warn',
+        'vue/prefer-import-from-vue': 'error',
         'vue/prefer-separate-static-class': 'error',
         'vue/prefer-true-attribute-shorthand': 'error',
         'vue/require-macro-variable-name': 'error',