Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_parse_result is called for each option #57

Open
KalleDK opened this issue Sep 7, 2023 · 1 comment
Open

handle_parse_result is called for each option #57

KalleDK opened this issue Sep 7, 2023 · 1 comment

Comments

@KalleDK
Copy link

KalleDK commented Sep 7, 2023

I don't know if this is working as intended, but it feels strange the handle_parse_result is called once for each option.

  • If you want to loop them, you can do so via self.get_options
  • All the implementations seems to ignore which option is currently being parsed
  • The field values is not changing based on callback on the option, so no real benefit there
@espdev
Copy link
Member

espdev commented Nov 2, 2023

Hello @KalleDK,

Click has an architecture that is quite difficult to extend. If you want to do something that isn't built into the click concept, things start to get complicated.

If you have any ideas on how to improve the code, I'm always happy to see a PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants