Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use <a> for external links to avoid i18n #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use <a> for external links to avoid i18n #88

wants to merge 2 commits into from

Conversation

Thechi2000
Copy link
Contributor

@Thechi2000 Thechi2000 commented Dec 22, 2024 •
edited
Loading

The <Link> components automatically inserts the language at the base of the uri if the domain matches, causing links to, for example, Nextcloud to break.

Closes #87

@Thechi2000 Thechi2000 added the bug Something isn't working label Dec 22, 2024
@Thechi2000 Thechi2000 self-assigned this Dec 22, 2024
@Thechi2000 Thechi2000 linked an issue Dec 22, 2024 that may be closed by this pull request
Language code added in front of URL of public files #87
Open
@Thechi2000 Thechi2000 marked this pull request as ready for review December 24, 2024 21:57
NoeTerrier
NoeTerrier requested changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@NoeTerrier NoeTerrier left a comment •
edited by Thechi2000
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that the document can be only stored behind our domain ? What if we what to refer to something on an external cloud ?

image
image

@Thechi2000
Copy link
Contributor Author

Does it mean that the document can be only stored behind our domain ? What if we what to refer to something on an external cloud ?

image
image

You need to set a full url in directus, e.g. https://www.example.org/my/document. If you use a relative path, it will break the link, and not much can be done about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoeTerrier NoeTerrier NoeTerrier requested changes

@SidonieBouthors SidonieBouthors Awaiting requested review from SidonieBouthors

Requested changes must be addressed to merge this pull request.

Assignees

@Thechi2000 Thechi2000

Labels
bug Something isn't working
Projects
CLIC website v2
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Language code added in front of URL of public files
2 participants
@Thechi2000 @NoeTerrier