feat(types,clerkjs,backend): Add support for enterprise_sso strategy #4596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4af970e The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nikpolik
force-pushed
the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
4 times, most recently
from
4557562
to
d676e5e
Compare
|
@Nikpolik Could we update We're already checking for active accounts within If tests start failing, we should probably introduce a |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nikpolik
force-pushed
the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
from
9975d2b
to
f1bac6d
Compare
Nikpolik
force-pushed
the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
from
f1bac6d
to
b2351cb
Compare
Handle the case of a sign in request that includes an identifier that matches the domain of an enterprise connection (SAML, Custom OAuth or EASIE). From version 2024-10-01 and onwards the API will respond with a status of `needs_first_factor`, the only strategy that will be included in supported first factors is `enterprise_sso` and the email address that matched will be returned in the identifier field. This commit updates the sign in component to read this new response and proceed with the enterprise_sso strategy.
When you enable SAML or any other enterprise sso strategy, both SAML and EnterprisSso will become enabled in the user_settings. Update the test helper to more closely reflect that.
Nikpolik
force-pushed
the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
from
b2351cb
to
97628f8
Compare
LauraBeatris
requested changes
Nov 25, 2024
| @@ -13,6 +13,7 @@ export type BackupCodeStrategy = 'backup_code'; | |||
| export type ResetPasswordPhoneCodeStrategy = 'reset_password_phone_code'; | |||
| export type ResetPasswordEmailCodeStrategy = 'reset_password_email_code'; | |||
| export type CustomOAuthStrategy = `oauth_custom_${string}`; | |||
| export type EnterpriseSSOStrategy = 'enterprise_sso'; | |||
There was a problem hiding this comment.
🔧 We should mark SamlStrategy as deprecated in favor of EnterpriseSSOStrategy:
/**
* @deprecated Use `EnterpriseSSOStrategy` instead
*/
export type SamlStrategy = 'saml';There was a problem hiding this comment.
Fixed f9c2194
Thanks for catching this, we need to mention it in the API docs as well I'll update them!
There was a problem hiding this comment.
Good catch on the docs, we'll need to update it here:
LauraBeatris
approved these changes
Nov 27, 2024
Nikpolik
force-pushed
the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
from
6d1b541
to
4af970e
Compare
panteliselef
approved these changes
Nov 28, 2024
Nikpolik
deleted the
nikpolik/user-939-add-support-for-enterprise_sso-strategy-in-clerkjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the new
enterprise_ssostrategy for signing in and signing up.This strategy supersedes SAML to provide a single strategy as the entry point for Enterprise Single Sign On regardless of the underlying protocol used to authenticate the user. For now there are two new types of connections that are supported in addition to SAML, Custom OAuth and EASIE (multi-tenant OAuth).
This new strategy will is available from API version
2024-10-01and after because the way the API responds for Sign In's with an email address that matches a SAML connection changes.From this version and onwards the API will respond with a status of
needs_first_factor, the only strategy that will be included in supported first factors isenterprise_ssoand the email address that matched will be returned in the identifier field. This change was made to make a bit clear the next step required.Changes
enterprise_ssoin responses and request types.enterprise_ssoin supported first factors.enterprise_ssoin missing fieldsSUPPORTED_API_VERSIONconstant to2024-10-01API Version
2024-10-01Besides this change updating the version to
2024-10-01will also enable the email's for Sign Ins from new clients feature.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change