-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDF internals, ray consensus, improved intersections performance #36
Open
clbarnes
wants to merge
17
commits into
master
Choose a base branch
from
signed-dist
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactors to reduce copies into numpy arrays, and use vecs of vecs less.
So that it is actually signed. Also some documentation.
- private method _sdf_intersections, which casts rays and returns the distance to a mesh and the dot product of the ray and the face normal - containment checks now may use signed distance, which is slower in real-world meshes but more robust - ray-based containment checks now may use consensus of a number of rays - different containment check strategies are benchmarked
switch to pseudonormal containment check is now n_rays=0 rather than None, due to PyO3/pyo3#3735
Downstream users should note:
|
@schlegelp @ceesem , probably best to pin your ncollpyde usage to <0.20 for now, then that can be bumped when the usage is updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercedes #34