Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(s?) with small temperature jump experiment. #86

Open
Peter9192 opened this issue Nov 25, 2024 · 3 comments
Open

Bug(s?) with small temperature jump experiment. #86

Peter9192 opened this issue Nov 25, 2024 · 3 comments

Comments

@Peter9192
Copy link
Member

To reproduce:

  1. Start with default config
  2. Add permutation, set initial temperature jump to 0.1 --> this produces a weird/buggy result, perhaps due to too large time step?
  3. Set time step to 0.1 --> Vertical profile plot has NaNs; timeseries plots nothing; diff view shows only time step, temp jump has been reset?
  4. Set time step to 1 --> Everything works okay again, except that the temp jump is still back to default
@Peter9192
Copy link
Member Author

It seems that modifying any experiment (reference or configuration) always only saves the latest modifications

@Peter9192
Copy link
Member Author

shouldDirty={true} means only modified values are returned.

shouldDirty={true} // Don't return empty strings for unset fields

Now, we're simply overwriting the old config with latest updates:

const { title, description, ...strippedConfig } = newConfig;

We should either update instead of replace the config
or set shouldDirty to false and prune the defaults after submission.

@Peter9192
Copy link
Member Author

#88 fixes the issue of multiple config modifications, so now we're left with buggy behaviour of class for the settings discussed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant