Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our form validations aren't in Spanish #1764

Closed
Niicck opened this issue Apr 24, 2019 · 7 comments
Closed

Our form validations aren't in Spanish #1764

Niicck opened this issue Apr 24, 2019 · 7 comments
Assignees
Labels
Bug Reported Copy; not code This may require edits to the codebase, but it isn't actually changing code, just content/copy P3 Priority 3: Don’t start something new until you fix this. Police Oversight Form Repo: Officer Complaint Form officer complaint form repos Team: Content Team: Dev
Milestone

Comments

@Niicck
Copy link
Collaborator

Niicck commented Apr 24, 2019

Describe the bug

Our form validations aren't in Spanish

URL
https://forms.austintexas.io/policia-queja/detalles-testigos
To Reproduce

Make a validation error on the /detalles-testigos

Current behavior

Error messages are in English.

Expected behavior

Show error messages in Spanish.

Screenshots

Screen Shot 2019-04-24 at 4.15.21 PM.png

Device

Windows 10, IE 11

@Niicck Niicck added Bug Reported P3 Priority 3: Don’t start something new until you fix this. Police Oversight Form Repo: Officer Complaint Form officer complaint form repos Team: Dev Team: Content Copy; not code This may require edits to the codebase, but it isn't actually changing code, just content/copy labels Apr 24, 2019
@easherma easherma self-assigned this Apr 25, 2019
@easherma
Copy link
Contributor

easherma commented Apr 29, 2019

Related: #1727
usds/us-forms-system#170
#1722

There are a rat's nest of translation issues here, but for the email translation, it is a matter of the translations.json looking for 'Please provide an email' vs 'Please enter an email', etc.

@easherma
Copy link
Contributor

@desigonz
For 'This field should be at least x characters(s)', we need a translation. Want to whip something up?

@easherma
Copy link
Contributor

cityofaustin/coa-forms#20 <--- adds in a fix for email. We'll need translations for other error messages, like the 'field should be at least x' example above

@desigonz
Copy link
Contributor

desigonz commented May 1, 2019

Por favor ingrese una dirección de correo electrónico válida

This field should be at least 10 characters (<---- get rid of the parentheticals around "s" on "characters")

Este campo debe tener por lo menos diez caracteres

@desigonz desigonz removed their assignment May 1, 2019
@oliver2g oliver2g added this to the Sprint 30 milestone May 6, 2019
@oliver2g oliver2g self-assigned this May 9, 2019
@oliver2g
Copy link
Contributor

oliver2g commented May 9, 2019

Still broken @easherma

  1. Correo electronico: wording doesn't match what @desigonz translated above:
    Desi's: "Por favor ingrese una dirección de correo electrónico válida"
    Staging: "Por favor provea una dirección válida

  2. Numero de telefono:
    "10 character(s)" should be "diez caracteres"

Screen Shot 2019-05-09 at 2 20 10 PM

@easherma
Copy link
Contributor

Should be fixed in staging now:
form

@desigonz
Copy link
Contributor

Verified that it's fixed on staging, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reported Copy; not code This may require edits to the codebase, but it isn't actually changing code, just content/copy P3 Priority 3: Don’t start something new until you fix this. Police Oversight Form Repo: Officer Complaint Form officer complaint form repos Team: Content Team: Dev
Projects
None yet
Development

No branches or pull requests

4 participants