Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race between ctxt shutdown, after suite listeners and reporters #289

Open
karnis opened this issue Sep 21, 2017 · 1 comment
Open

Race between ctxt shutdown, after suite listeners and reporters #289

karnis opened this issue Sep 21, 2017 · 1 comment
Labels
Prio: Low State: To discuss In case there are open questions concerning the issue Type: Enhancement

Comments

@karnis
Copy link
Contributor

karnis commented Sep 21, 2017

I understand that this issue duplicates or even causes #103.

Both the spring ctxt shutdown as well as the after suite notifications are being run in parallel in two different JVM shutdown hooks. Now interacting with ctxt beans while shutting down the ctxt at the same time is an error-prone race.

What seems to me as a potential solution to this problem is introducing an @Ordered race-free shutdown sequence moving the AfterSuiteShutdownHook to be a ApplicationListener<ContextClosedEvent> participating in the spring ctxt shutdown.

@christophd?

@christophd christophd added Type: Enhancement READY State: To discuss In case there are open questions concerning the issue labels Sep 21, 2017
@christophd christophd added this to the v2.7.3 milestone Sep 21, 2017
@christophd christophd added IN PROGRESS and removed READY State: To discuss In case there are open questions concerning the issue labels Nov 13, 2017
@christophd christophd modified the milestones: v2.7.3, v2.7.4 Dec 18, 2017
@christophd christophd modified the milestones: v2.7.4, SOMEDAY Mar 12, 2018
@svettwer svettwer removed this from the SOMEDAY milestone Jul 20, 2018
@svettwer svettwer added State: To discuss In case there are open questions concerning the issue and removed READY labels Jan 24, 2019
@svettwer
Copy link
Contributor

Hi!

Even if this is an older issue: would it be possible for you to check whether the problem still exists with the newer Citrus versions and provide a sample test case if it does?

BR,
Sven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Low State: To discuss In case there are open questions concerning the issue Type: Enhancement
Projects
None yet
Development

No branches or pull requests

3 participants