Skip to content

Commit

Permalink
Feature ever 13205 a11y buttons and links (#311)
Browse files Browse the repository at this point in the history
* feat: Add Modal component (#309)

* feat: Add Modal component

* cleaned up css class names

* add logic to auto focus and focus trapping in the modal

* Add example of Modal usage

* update unit test by adding snapshot to verify the component renders what is expected in the UI

* fix: Modal focus trap works better with keydown listener, add focus trap tests, upgrade testing-library packages

* fix: use userEvent.type to simulate escape key press

* fixed failing test

Co-authored-by: Boima Konuwa <[email protected]>
Co-authored-by: Chris Garcia <[email protected]>

* feat: EVER-13212: a11y colors for buttons and text links

Co-authored-by: bkonuwa <[email protected]>
Co-authored-by: Boima Konuwa <[email protected]>
  • Loading branch information
3 people committed Aug 24, 2021
1 parent b692909 commit f2b3003
Show file tree
Hide file tree
Showing 15 changed files with 560 additions and 298 deletions.
14 changes: 9 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ All notable changes to this project will be documented in this file. Dates are d

Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

#### [v3.0.0](https://github.com/cision/rover-ui/compare/v3.0.0-alpha.1...v3.0.0)
#### [v4.0.0-alpha.1](https://github.com/cision/rover-ui/compare/v3.0.0-alpha.1...v4.0.0-alpha.1)

- V3.0.0 alpha.1 [`#335`](https://github.com/cision/rover-ui/pull/335)
- chore: Update Kite snapshop test to reflect v3 button class names [`#334`](https://github.com/cision/rover-ui/pull/334)
- feat: EVER-13206: a11y focus states for buttons and links [`#317`](https://github.com/cision/rover-ui/pull/317)
- Feature ever 13205 a11y buttons and links [`#311`](https://github.com/cision/rover-ui/pull/311)
- Chore: Deprecate Node 10.x support [`#336`](https://github.com/cision/rover-ui/pull/336)

#### [v3.0.0-alpha.1](https://github.com/cision/rover-ui/compare/v2.10.2...v3.0.0-alpha.1)
Expand Down Expand Up @@ -77,7 +81,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- Bump ini from 1.3.5 to 1.3.8 in /example [`#287`](https://github.com/cision/rover-ui/pull/287)
- Bump dot-prop from 4.2.0 to 4.2.1 in /example [`#286`](https://github.com/cision/rover-ui/pull/286)
- v2.4.8 [`#285`](https://github.com/cision/rover-ui/pull/285)
- fix: #279 Button passed as prop overrides default. [`#282`](https://github.com/cision/rover-ui/pull/282)
- fix: #279 Button passed as prop overrides default. [`#282`](https://github.com/cision/rover-ui/pull/282)
- docs: Update CONTRIBUTING.md, move publishing info to PUBLISHING.md [`#278`](https://github.com/cision/rover-ui/pull/278)
- Chore: remove exclusive test and add prop type for test component [`#277`](https://github.com/cision/rover-ui/pull/277)

Expand Down Expand Up @@ -251,8 +255,8 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).

> 1 June 2020
- Add basic Input component wrapper. [`#204`](https://github.com/cision/rover-ui/pull/204)
- Add basic Input component wrapper. (#204) [`#202`](https://github.com/cision/rover-ui/issues/202)
- Add basic Input component wrapper. [`#204`](https://github.com/cision/rover-ui/pull/204)
- Add basic Input component wrapper. (#204) [`#202`](https://github.com/cision/rover-ui/issues/202)

#### [v1.4.5](https://github.com/cision/rover-ui/compare/v1.4.4...v1.4.5)

Expand Down Expand Up @@ -358,7 +362,7 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
- B and C named icons [`#132`](https://github.com/cision/rover-ui/pull/132)
- Add social icons to Icon component [`#124`](https://github.com/cision/rover-ui/pull/124)
- Callout (#135) [`#131`](https://github.com/cision/rover-ui/issues/131)
- replaced svgs w smaller files [`73adcd4`](https://github.com/cision/rover-ui/commit/73adcd4902947bee1b28ffec2e2e7b6af38c6801)
- replaced svgs w smaller files [`73adcd4`](https://github.com/cision/rover-ui/commit/73adcd4902947bee1b28ffec2e2e7b6af38c6801)
- added social icons to icon component [`b3ea266`](https://github.com/cision/rover-ui/commit/b3ea2669656e11c6ab7fa11ddf0fccbefca2873c)
- replaced Icon in test file with new icon. original was deleted as it was redundant [`1003223`](https://github.com/cision/rover-ui/commit/1003223f54aceafd68c067074d962358a3585f06)
- big fixes and added more icons [`d790664`](https://github.com/cision/rover-ui/commit/d790664854f1603a7bfb67713d66b40850668a37)
Expand Down
29 changes: 24 additions & 5 deletions PUBLISHING.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
## Publishing a new version
# Publishing a new version

To publish the npm package, you'll need an [npm](https://www.npmjs.com/) account, and you'll need to be added to the list of maintainers by one of the current RoverUI maintainers.

### With write access
## With write access

1. Checkout a release branch of some kind: (e.g. `release-2.0.4` or `new-v2.1.4`)
2. **Following [semver](https://semver.org)** as your version guide, use the script `yarn new-version [value]` to bump the version. See [`yarn version`](https://classic.yarnpkg.com/en/docs/cli/version/) docs for more info
Expand All @@ -17,7 +17,7 @@ To publish the npm package, you'll need an [npm](https://www.npmjs.com/) account
2. `yarn publish`
6. Ask an admin to push your new version's tag to GitHub.

### With admin access
## With admin access

If you're an [admin](https://github.com/cision/rover-ui/settings/access), you can commit directly to `master`. The process is much more streamlined.

Expand All @@ -26,7 +26,7 @@ If you're an [admin](https://github.com/cision/rover-ui/settings/access), you ca
3. `yarn publish` (also pushes new tag to GitHub)
4. `git push` to push your `master` branch with the updated CHANGELOG.md generated by our publish scripts

### Drafting a release
## Drafting a release

After your tag is published, you should create a GitHub release from it.

Expand All @@ -38,10 +38,29 @@ After your tag is published, you should create a GitHub release from it.
6. Ideally, the commits should be human-readable and clear, but you may want to do some light editing.
7. When you're satisfied, publish the release.

## Publishing Storybook
# Publishing Storybook

By default, our Storybook docs are published automatically using ![Github Actions](.github/workflows/gh-pages.yml). If there is an issue with this release or you need to publish this manually, use the following command:

```sh
yarn storybook:deploy
```

# Publishing a pre-release version

You should only do this if you're an admin.

Edit the version in `package.json` manually. Pre-release versions should be named in this format:

```
v{MAJOR}.0.0-alpha.{BUILD}
```

"MAJOR" is the intended major version. Each time you deploy a new alpha build, increment the "BUILD" number.
For example, `v4.0.0-alpha.1` is the first iteration of what will one day become v4.

Then, from the command line:

```sh
yarn update-changelog
```
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cision/rover-ui",
"version": "3.0.0",
"version": "4.0.0-alpha.1",
"description": "UI Component Library",
"author": "Matthew Wells (https://github.com/mdespuits)",
"contributors": [
Expand Down
4 changes: 2 additions & 2 deletions src/components/Avatar/Avatar.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
justify-content: center;
align-items: center;
color: white;
background-color: var(--rvr-blue);
background-color: var(--rvr-color-primary);
background-position: center;
background-size: cover;
}
Expand All @@ -16,7 +16,7 @@
animation-iteration-count: infinite;
animation-name: imagePlaceholderShimmer;
animation-timing-function: linear;
background: linear-gradient(to right, var(--rvr-blue) 2%, var(--rvr-blue-lite-1) 18%, var(--rvr-blue) 33%);
background: linear-gradient(to right, var(--rvr-color-primary) 2%, var(--rvr-blue-lite-1) 18%, var(--rvr-color-primary) 33%);
background-size: 1200px 10px;
position: relative;
}
Expand Down
Loading

0 comments on commit f2b3003

Please sign in to comment.