Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

GET get_breaches() Convert to API Endpoint #701

Closed
4 of 6 tasks
Tracked by #13
arng4108 opened this issue Jan 22, 2024 · 1 comment
Closed
4 of 6 tasks
Tracked by #13

GET get_breaches() Convert to API Endpoint #701

arng4108 opened this issue Jan 22, 2024 · 1 comment
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@arng4108
Copy link
Contributor

arng4108 commented Jan 22, 2024

💡 Summary

Replace the existing TSQL function with a new REST endpoint that does the same thing
Specifically: Convert "get_breaches()" TSQL query to an API endpoint

Motivation and context

There are two major reasons to use endpoints in place of sql queries.

  • Replace the need to know t-sql
  • Off load data aggregation to fastapi parallel workers

Implementation notes

  • Gather existing queries from code.
  • Create new endpoints at fastapi.
  • Secure new endpoints in same fashion as existing endpoint.

Acceptance criteria

  • home/models.py model created
  • dataAPI/schemas.py schema created
  • dataAPI/views.py functions created
  • dataAPI/tasks.py function created (if applicable)
  • Verified endpoint is working
  • pushed to api extended/staging branch
@arng4108 arng4108 added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jan 22, 2024
@arng4108 arng4108 self-assigned this Jan 22, 2024
@schmelz21
Copy link
Collaborator

Closing s all endpoint testing has moved to this #705.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Archived in project
Development

No branches or pull requests

2 participants