Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Alter modules to be class oriented #692

Open
cduhn17 opened this issue Nov 29, 2023 · 0 comments
Open

Alter modules to be class oriented #692

cduhn17 opened this issue Nov 29, 2023 · 0 comments
Assignees
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use

Comments

@cduhn17
Copy link
Collaborator

cduhn17 commented Nov 29, 2023

💡 Summary

The current state is the modules pe_source, pe_scorecard and breakout the database connection into a module and convert into classes where possible.

Motivation and context

We need to have a generic database connection class to limit the scope of each of the modules. The pe_reports module currently has the database connection code and it should be more generic, to be used anywhere necessary in the repo.

Implementation notes

Classify the modules and convert scripts to methods of a class.

Acceptance criteria

How do we know when this work is done?

  • [ ]Do all modules contain a parent class with methods
  • [ ]Are the imported module scripts methods of the class
@cduhn17 cduhn17 added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 29, 2023
@cduhn17 cduhn17 self-assigned this Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

No branches or pull requests

1 participant