Allow running provisioners when recovery = true

[roblabla]

Currently when recovery = true, the provisioners will not run, as evidenced by this piece of code. I don't quite understand why. My use-case is having a packer file that boots the VM to recovery to disable SIP, reboot, and then run the repackaging steps to install some software. Would you be open to adapting the behavior to allow this use-case?

[edigaryev]

I don't quite understand why.

Because there's no SSH when the VM is running in the recovery mode, and thus no provisioning capability

If we were to run the VM multiple times in a single packer build (let's say first with --recovery, and then without), it would be hard go grasp to which stage the boot_command and other configuration options will apply.

This is the reason we have a separate Packer configuration solely for disabling SIP, for example.

[roblabla]

Because there's no SSH when the VM is running in the recovery mode, and thus no provisioning capability

Sure, but it's possible to reboot from recovery mode into normal mode, and have ssh from there. My boot_command does that, and I was very surprised when the provisioners weren't being run. I find the current behavior way more surprising, because my expectation is that packer will always try to run the provisioners 👀.

At the very least, I think this deserves to be documented somewhere (like here), because right now it's just a complete head-scratcher without reading the source ^^'.

---

For my use-case, I'm toying with the idea of making a custom provisioner that reboots the VM in recovery mode, does its shenanigans over VNC, and reboots it back to normal, essentially moving from having recovery: true in the builder to having a proper provisioning step that can be inserted with any other.