Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maxAliasesForCollections override #136

Closed
hcdeng opened this issue Aug 31, 2020 · 4 comments
Closed

Support maxAliasesForCollections override #136

hcdeng opened this issue Aug 31, 2020 · 4 comments

Comments

@hcdeng
Copy link
Collaborator

hcdeng commented Aug 31, 2020

SnakeYaml defaults "maxAliasesForCollections" to 50, and supports overriding this value via https://www.javadoc.io/doc/org.yaml/snakeyaml/latest/org/yaml/snakeyaml/LoaderOptions.html. This would probably be implemented the same way as #120.

We have a project that parses yml files with more than 50 aliases - currently using a workaround for this.

@hcdeng
Copy link
Collaborator Author

hcdeng commented Sep 1, 2020

Starting work on this

@ajj-stripe
Copy link

Would very much appreciate if you could implement #120 at the same time, but totally understand if it requires significant extra effort

@hcdeng
Copy link
Collaborator Author

hcdeng commented Jul 19, 2021

Doesn't seem like too much work, but the PR for maxAliasesForCollections is (hopefully) only a couple button clicks away from getting merged. Once it's in, adding #120 should be pretty small/straightforward. If it happens in the next couple of weeks, I should have time to tackle it.

@jeffmay
Copy link
Contributor

jeffmay commented Mar 2, 2023

@jeffmay jeffmay closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants