Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null values in ODF files #75

Open
n-a-t-e opened this issue Mar 25, 2021 · 3 comments
Open

Null values in ODF files #75

n-a-t-e opened this issue Mar 25, 2021 · 3 comments

Comments

@n-a-t-e
Copy link
Member

n-a-t-e commented Mar 25, 2021

It looks like OCE handes null values in ODF files well, but would be good to review how this works and how we will set appropriate attributes in ERDDAP. @JessyBarrette has started on this work

@pramod-thupaki
Copy link
Contributor

Setting _FillValue attribute in the netcdf file at time of creation works well with ERDDAP in my experience. No changes need to be made on the 'datasets.xml' used by ERDDAP.

@JessyBarrette
Copy link
Collaborator

I believe OCE converts floats and time to NaN, haven't confirmed yet anything about Integers values.

Since addvar requests a null_value as an input. This had to be handle within the addvar integration of the different variables. Otherwise, just using a place holder like NaN would fail with integer variables.

@pramod-thupaki
Copy link
Contributor

pramod-thupaki commented Mar 25, 2021

the null_value that you pass to add_var is designed to catch and convert values like '99' or '99.99' that are non-NaN null_values; you can also pass None or np.nan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants