Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameError: name 'ConvergenceError' is not defined #521

Open
PhilippHoellmer opened this issue Feb 13, 2024 · 0 comments
Open

NameError: name 'ConvergenceError' is not defined #521

PhilippHoellmer opened this issue Feb 13, 2024 · 0 comments

Comments

@PhilippHoellmer
Copy link

In line 1963 of pymbar/pymbar/mbar.py, the code tries to catch a ConvergenceError that is nowhere defined in that file. Hence, if that part of the code is reached, one gets a NameError.

The simple solution is to import the ConvergenceError from pymbar.utils at the top of the file.

As a related question: At the same place of the code, would it also make sense to catch the pymbar.utils.BoundsError that, as the pymbar.utils.ConvergenceError, can be thrown by the bar function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant