Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is very hard to find the design / example list now #370

Open
mithro opened this issue Dec 6, 2022 · 6 comments
Open

It is very hard to find the design / example list now #370

mithro opened this issue Dec 6, 2022 · 6 comments
Assignees

Comments

@mithro
Copy link
Contributor

mithro commented Dec 6, 2022

The only place the designs and examples are listed is on the page @ https://f4pga-examples.readthedocs.io/en/latest/building-examples.html and they no longer appear in the left side bar.

@mithro
Copy link
Contributor Author

mithro commented Dec 6, 2022

@umarcor - This seems to be a regression / step backwards for usability.....

@mithro
Copy link
Contributor Author

mithro commented Dec 6, 2022

It was almost impossible for me to find the demos which run on the Zynq to answer the question at #26

@mithro
Copy link
Contributor Author

mithro commented Dec 6, 2022

@kgugala - PTAL - I think the listing / menu thing is affecting many users of the theme.

@mithro
Copy link
Contributor Author

mithro commented Dec 7, 2022

BTW - This is what the example page looks like to me, I can't see any examples at first glance (have to scroll down);
image

@kgugala
Copy link
Member

kgugala commented Dec 7, 2022

yeah, @umarcor is working on this (experimenting with a few different desings to figure out which will be most readable)

@umarcor
Copy link
Contributor

umarcor commented Dec 7, 2022

I pushed eight tests to https://github.com/antmicro/f4pga-examples/blob/gh-pages. See https://github.com/antmicro/f4pga-examples/blob/gh-pages/theme_tests.md.

Therefore, it seems that the theme needs to be modified in order to allow globaltoc_depth > 1. Particularly, collapsible items should have two parts:

  • The text should keep linking to the corresponding page.
  • The caret, and only the caret, should collapse/expand the children.

Alternatively, the theme might be modified so that the depth of the right sidebar is also configurable through theme options. Currently, the left does show children by traversing toctrees, but the right seems to only include sections of the current page, not children traversing toctrees. Then, it would not mind if the items on the left sidebar are not collapsible because all of them would be expanded on the right.

It is surprising that the left sidebar seems to be broken in the latest version of the upstream. It might be related to some recent changes in Sphinx, since the theme was not updated since Oct 2021. Another user reported it: bashtage/sphinx-material#128.

Per f4pga/sphinx_f4pga_theme@2dd4934 and f4pga/sphinx_f4pga_theme@09ae77d, maybe @daniellimws can provide some insight?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants