Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mldsa_ctrl sends last data to keccak in state func_start #46

Open
cbatlubis opened this issue Nov 25, 2024 · 0 comments
Open

mldsa_ctrl sends last data to keccak in state func_start #46

cbatlubis opened this issue Nov 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@cbatlubis
Copy link

Module mldsa_ctrl in state MLDSA_CTRL_MSG_LOAD (line 1242) sends data to keccak and uses ready/valid-handshaking for the synchronisation.
From our understanding, the last message sent is the integer literal "'h0708" (padding).
However, in our counterexamples is seems that mldsa_ctrl is sending this last message in state MLDSA_CTRL_FUNC_START (instead of state MLDSA_CTRL_MSG_LOAD) which does the unconditional transition to state MLDSA_CTRL_DONE.
This includes that it does not wait for any ready signal.

This behaviour looks odd to us.

@mojtaba-bisheh mojtaba-bisheh added the bug Something isn't working label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants