Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve <br>? #4

Open
8enmann opened this issue Oct 15, 2018 · 4 comments
Open

Preserve <br>? #4

8enmann opened this issue Oct 15, 2018 · 4 comments

Comments

@8enmann
Copy link

8enmann commented Oct 15, 2018

I tried extracting https://us13.campaign-archive.com/?u=67bd06787e84d73db24fb0aa5&id=c3e998f811&e=7bc177b38a

and then rendering it. Looks broken since the
are extracted. Can I send a PR to add them back? What's the best way to do this?

@chimbori
Copy link
Owner

Sure, PRs are always welcome! See CONTRIBUTIONS for how to send one.

At a minimum, please add a new test with the content you are trying to parse, and then modify the source so that your new text is parsed correctly (while ensuring that existing tests also continue to pass.)

@8enmann
Copy link
Author

8enmann commented Oct 25, 2018

Decided to use mozilla/readability instead since it's a bit more robust. Thanks!

@chimbori
Copy link
Owner

True, it’s been around longer & has more maintainers.

Though, it’s written in JavaScript, which precludes many usages of it, especially in Android apps. Crux’s predecessor, Snacktory, started as a Java clone of Readability.

@8enmann
Copy link
Author

8enmann commented Oct 25, 2018

In Android I'm injecting it into a WebView and extracting output with webview.evaluateJavascript 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants