Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add seed to film grain node #439

Open
exnex opened this issue Dec 4, 2024 · 4 comments
Open

Suggestion: add seed to film grain node #439

exnex opened this issue Dec 4, 2024 · 4 comments

Comments

@exnex
Copy link

exnex commented Dec 4, 2024

Your node set here is amazing! I'm using it for processing videos, and I'm so happy to find it runs batches without any issue.
But the film grain node doesn't have seed option, so the noise looks the same on each frame. The only other node I could find for this was from ProPost node set, but the node itself seems to run slow / has more variables.

Would it be possible to add a v2 of this node with seed (option for fixed/random/increment)? thank you

@exnex exnex changed the title Suggetsion: add seed to film grain nodes. Suggestion: add seed to film grain nodes. Dec 4, 2024
@exnex exnex changed the title Suggestion: add seed to film grain nodes. Suggestion: add seed to film grain node Dec 4, 2024
@chflame163
Copy link
Owner

Thank you for your suggestion. The random seed noise has been added, and now each run will produce different noise.

@exnex
Copy link
Author

exnex commented Dec 14, 2024

thank you! Is this live now? I've tried running this and the issue still persists. Maybe its because im processing a batch of images through it? it would need to apply a different seed to each image in a batch on one run to work for videos

@chflame163
Copy link
Owner

thank you! Is this live now? I've tried running this and the issue still persists. Maybe its because im processing a batch of images through it? it would need to apply a different seed to each image in a batch on one run to work for videos

Can you attach the simplest workflow that cannot generate random noise?

@chflame163
Copy link
Owner

I have modified the code for random noise again, hoping it can meet your requirements this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants