Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Design Request: Show skill rank icon in hero drop down menu if player has Battletag #133

Open
RobThePM opened this issue May 31, 2017 · 2 comments
Labels
design User interface, art, CSS enhancement New features

Comments

@RobThePM
Copy link
Collaborator

Can we show the skill rank icon (e.g. bronze icon, silver icon, etc.) next to the corresponding hero in the hero drop down menu? If it's possible to add the hero portrait in the drop down menu that would be awesome, too, but that's something that could easily be pushed to a future version.

--- Current hero drop down ---

https://gyazo.com/af71db75450369a496866b1e39ee0ceb

--- Concept hero drop down ---

sample - hero drop down menu

@RobThePM RobThePM added design User interface, art, CSS enhancement New features labels May 31, 2017
@cheshire137
Copy link
Owner

We can do this!

The implementation for this will actually help us solve #83. The problem here and for that issue is that we're using a plain HTML <select> menu for the hero menu and the map menu. We need to do something custom with another kind of HTML element, like a <ul> of <li>s that can have images in them and custom styling. The dropdowns in Bootstrap are akin to what we want, though we don't want to pull in Bootstrap just for this. We can use custom logic in React and similar styling, though.

@RobThePM
Copy link
Collaborator Author

Sweet! I think it will be a great feature and also be a nice visual for our users!

@cheshire137 cheshire137 self-assigned this Jul 15, 2017
@cheshire137 cheshire137 removed their assignment Jul 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design User interface, art, CSS enhancement New features
Projects
None yet
Development

No branches or pull requests

2 participants