From 59a711eabe90e91f91d61bc7b8fc0fab8b88d89c Mon Sep 17 00:00:00 2001
From: William Banfield <4561443+williambanfield@users.noreply.github.com>
Date: Wed, 7 Sep 2022 21:00:07 -0400
Subject: [PATCH] test: generate uuid on startup for load tool (#9383)

the `NewClient` method is called by the load test framework for each connection. This means that if multiple connections are instantiated, each connection will erroneously have its own UUID. This PR changes the UUID generation to happen at the _beginning_ of the script instead of on client creation so that each experimental run shares a UUID.

Caught while preparing the script for production readiness.

#### PR checklist

- [ ] Tests written/updated, or no tests needed
- [ ] `CHANGELOG_PENDING.md` updated, or no changelog entry needed
- [ ] Updated relevant documentation (`docs/`) and code comments, or no
      documentation updates needed
---
 test/loadtime/cmd/load/main.go | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/test/loadtime/cmd/load/main.go b/test/loadtime/cmd/load/main.go
index ff90b696c3e..7eceaea7da8 100644
--- a/test/loadtime/cmd/load/main.go
+++ b/test/loadtime/cmd/load/main.go
@@ -15,7 +15,9 @@ var (
 )
 
 // ClientFactory implements the loadtest.ClientFactory interface.
-type ClientFactory struct{}
+type ClientFactory struct {
+	ID []byte
+}
 
 // TxGenerator is responsible for generating transactions.
 // TxGenerator holds the set of information that will be used to generate
@@ -28,7 +30,8 @@ type TxGenerator struct {
 }
 
 func main() {
-	if err := loadtest.RegisterClientFactory("loadtime-client", &ClientFactory{}); err != nil {
+	u := [16]byte(uuid.New()) // generate run ID on startup
+	if err := loadtest.RegisterClientFactory("loadtime-client", &ClientFactory{ID: u[:]}); err != nil {
 		panic(err)
 	}
 	loadtest.Run(&loadtest.CLIConfig{
@@ -51,9 +54,8 @@ func (f *ClientFactory) ValidateConfig(cfg loadtest.Config) error {
 }
 
 func (f *ClientFactory) NewClient(cfg loadtest.Config) (loadtest.Client, error) {
-	u := [16]byte(uuid.New())
 	return &TxGenerator{
-		id:    u[:],
+		id:    f.ID,
 		conns: uint64(cfg.Connections),
 		rate:  uint64(cfg.Rate),
 		size:  uint64(cfg.Size),