Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Environment variables containing # are cut off #970

Closed
tdeekens opened this issue Oct 22, 2024 · 3 comments
Closed

bug: Environment variables containing # are cut off #970

tdeekens opened this issue Oct 22, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tdeekens
Copy link

Node.js version

22

NPM version

10

@checkly/cli version

4.9.1

Steps to reproduce

Create any check (API or Browser). This check must contain an environment variable (secret or not) such as:

environmentVariables: [
 {
    key: 'FOO',
    value: 'bar#baz',
    secret: true,
 },
]

What is expected?

The environment variable should be deployed under the check itself with the value bar#baz. When deploying it as an environment variable it's visible it's cropped off. When using a secret not directly but when entered e.g. into a password field the string is noticeable shorter.

What is actually happening?

Said environment variable is however saved as bar. So essentially cropped off at the #.

Any additional comments?

I've noticed the same in the Checkly UI when trying to update the environment variable. At first it appears to be saved as bar#baz but when saving and reloading it again is cropped at bar.

This seems to correlate with the release of the Secrets for sensitive data release. Of course this is just a guess.

@tdeekens tdeekens added the bug Something isn't working label Oct 22, 2024
@Antoine-C
Copy link
Contributor

Hello @tdeekens,

Thanks for the report, I'm taking a look and will get back to you asap. Thanks!

@Antoine-C Antoine-C self-assigned this Oct 22, 2024
@Antoine-C
Copy link
Contributor

@tdeekens I can't reproduce the issue, having an environment variable (clear, locked and/or secret) with a value as foo#bar doesn't cause any trouble on my end.

Could you send me over (in our Slack community or by email at [email protected]) your accountId - checkId so I can take a look?

@sorccu
Copy link
Collaborator

sorccu commented Dec 4, 2024

Closing as I believe this issue was resolved (or rather, could not be reproduced). Thank you for the report regardless!

@sorccu sorccu closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants