From 3809e2b8c2d66b92b9f08955c107cf8457286d3f Mon Sep 17 00:00:00 2001 From: Charles Duffy Date: Mon, 22 Jan 2024 18:00:40 -0600 Subject: [PATCH] Add requirements.txt to sdist, remove README.md from data_files Fixes #47. - `requirements.txt` being missing from the source tarball meant that this package was only possible to install from the wheel, not from the sdist; one can reproduce the problem by using `--no-binary :all:` as an argument to `pip`. - Adding `README.md` to `data_files` meant that it was installed into site-packages instead of only being added to the source tarball; being at the root, it conflicted with any _other_ Python package trying to install a README.md when using a package manager that tracks such conflicts. --- MANIFEST.in | 1 + setup.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 MANIFEST.in diff --git a/MANIFEST.in b/MANIFEST.in new file mode 100644 index 0000000..b2672cc --- /dev/null +++ b/MANIFEST.in @@ -0,0 +1 @@ +include README.md requirements.txt diff --git a/setup.py b/setup.py index 4708b4a..1bdbadf 100644 --- a/setup.py +++ b/setup.py @@ -25,7 +25,6 @@ def _read_reqs(relpath): author="Romain Beaumont", author_email="romain.rom1@gmail.com", url="https://github.com/rom1504/embedding-reader", - data_files=[(".", ["README.md"])], keywords=["machine learning"], install_requires=REQUIREMENTS, classifiers=[