Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(callout): new hideTitle and hideBody props and a component slot #910

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor(callout): new hideTitle and hideBody props and a component slot #910

wants to merge 2 commits into from

Conversation

masoudmanson
Copy link
Contributor

Summary

Callout
Github issue: #909

Refactor the Callout component with the following updates:

  • Add a component slot for extraContent, allowing additional content to be placed at the bottom of the Callout component.
  • Introduce two new props to toggle the visibility of the calloutTitle and calloutText.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 26, 2024 that may be closed by this pull request
Refactor Callout component #909
Open
@masoudmanson masoudmanson self-assigned this Nov 26, 2024
@masoudmanson masoudmanson added Ready for review This PR is ready for review and removed Work in Progress This PR is a work in progress labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tihuan tihuan Awaiting requested review from tihuan

@clarsen-czi clarsen-czi Awaiting requested review from clarsen-czi

At least 1 approving review is required to merge this pull request.

Assignees

@masoudmanson masoudmanson

Labels
Eng P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Callout component
1 participant
@masoudmanson