Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tooltipcondensed): add hasInvertedStyle prop to TooltipCondensed #908

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(tooltipcondensed): add hasInvertedStyle prop to TooltipCondensed #908

wants to merge 1 commit into from

Conversation

masoudmanson
Copy link
Contributor

Summary

Structural Element (Base, Gene, DNA, Chromosome or Cell)
Github issue: #907

Add a hasInvertedStyle prop to the TooltipCondensed component, similar to the existing Tooltip component, to support different style variations.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 26, 2024 that may be closed by this pull request
Add hasInvertedStyle prop to TooltipCondensed component #907
Open
@masoudmanson masoudmanson self-assigned this Nov 26, 2024
@masoudmanson masoudmanson added Bug Something isn't working P0 Ready for review This PR is ready for review labels Nov 26, 2024
clarsen-czi
clarsen-czi approved these changes Nov 27, 2024
View reviewed changes
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks @masoudmanson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarsen-czi clarsen-czi clarsen-czi approved these changes

@tihuan tihuan Awaiting requested review from tihuan

Assignees

@masoudmanson masoudmanson

Labels
Bug Something isn't working P0 Ready for review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hasInvertedStyle prop to TooltipCondensed component
2 participants
@masoudmanson @clarsen-czi