Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputCheckbox): refactor InputCheckbox and InputRadio #904

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

masoudmanson
Copy link
Contributor

@masoudmanson masoudmanson commented Nov 23, 2024

Summary

InputCheckbox & InputRadio
Github issue: #903

The current SDS control icons need to be updated to use JSX elements with the new Check icon. The issue with the current implementation is that the checked checkbox is hollow, allowing the background color to show through. This causes design inconsistencies when the checkbox is placed on backgrounds other than white (in light mode) or black (in dark mode).

To resolve this, the checkbox design should be updated to feature a solid filled square with the Check icon overlayed on top. The icon’s color should dynamically adjust based on the theme to ensure consistency across different background colors.

The same changes are needed for the InputRadio component.

Checklist

  • Default Story in Storybook
  • LivePreview Story in Storybook
  • Test Story in Storybook
  • Tests written
  • Variables from defaultTheme.ts used wherever possible
  • If updating an existing component, depreciate flag has been used where necessary
  • Chromatic build verified by @chanzuckerberg/sds-design

@masoudmanson masoudmanson linked an issue Nov 23, 2024 that may be closed by this pull request
@masoudmanson masoudmanson self-assigned this Nov 23, 2024
@masoudmanson masoudmanson added Eng Ready for review This PR is ready for review labels Nov 23, 2024
@masoudmanson masoudmanson added Work in Progress This PR is a work in progress P1 Ready for review This PR is ready for review and removed Ready for review This PR is ready for review Work in Progress This PR is a work in progress labels Nov 23, 2024
Copy link

@clarsen-czi clarsen-czi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @masoudmanson!! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Eng P1 Ready for review This PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor InputCheckbox and InputRadio icons
2 participants