-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(InputCheckbox): refactor InputCheckbox
and InputRadio
#904
Open
masoudmanson
wants to merge
11
commits into
main
Choose a base branch
from
903-refactor-inputcheckbox-and-inputradio-icons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(InputCheckbox): refactor InputCheckbox
and InputRadio
#904
masoudmanson
wants to merge
11
commits into
main
from
903-refactor-inputcheckbox-and-inputradio-icons
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into 901-refactor-theme-and-variables-based-on-updated-color-design-in-figma
masoudmanson
added
Work in Progress
This PR is a work in progress
P1
Ready for review
This PR is ready for review
and removed
Ready for review
This PR is ready for review
Work in Progress
This PR is a work in progress
labels
Nov 23, 2024
clarsen-czi
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @masoudmanson!! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
InputCheckbox & InputRadio
Github issue: #903
The current SDS control icons need to be updated to use JSX elements with the new
Check
icon. The issue with the current implementation is that the checked checkbox is hollow, allowing the background color to show through. This causes design inconsistencies when the checkbox is placed on backgrounds other than white (in light mode) or black (in dark mode).To resolve this, the checkbox design should be updated to feature a solid filled square with the
Check
icon overlayed on top. The icon’s color should dynamically adjust based on the theme to ensure consistency across different background colors.The same changes are needed for the
InputRadio
component.Checklist
defaultTheme.ts
used wherever possible