Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed dropdown property to AlphaIconButton #2490

Open
yangwooseong opened this issue Nov 8, 2024 · 1 comment
Open

Add missed dropdown property to AlphaIconButton #2490

yangwooseong opened this issue Nov 8, 2024 · 1 comment
Labels
enhancement Issues or PR related to making existing features better

Comments

@yangwooseong
Copy link
Collaborator

yangwooseong commented Nov 8, 2024

Description

AlphaIconButtondropdown속성을 추가합니다.

Reasons for suggestion

chevron-small-down 혹은 chevron-small-up 아이콘을 보여줄 수 있는 dropdown 속성이 누락되어 있습니다.

Proposed solution

interface IconButtonOwnProps {
  dropdown?: 'chevron-small-down' | 'chevron-small-up' 
}

유니언 타입의 dropdown 속성을 인터페이스에 추가하고, 컴포넌트 내부에서 베지어 아이콘으로 맵핑합니다.

References

@yangwooseong yangwooseong added the enhancement Issues or PR related to making existing features better label Nov 8, 2024
Copy link

channeltalk bot commented Nov 8, 2024

@yangwooseong yangwooseong changed the title Add missed dropdown property to IconButton Add missed dropdown property to AlphaIconButton Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues or PR related to making existing features better
Projects
None yet
Development

No branches or pull requests

1 participant