Skip to content

Commit

Permalink
Remove LegacySegmentedControl and related utils (#1786)
Browse files Browse the repository at this point in the history
<!--
  How to write a good PR title:
- Follow [the Conventional Commits
specification](https://www.conventionalcommits.org/en/v1.0.0/).
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

## Self Checklist

- [x] I wrote a PR title in **English** and added an appropriate
**label** to the PR.
- [x] I wrote the commit message in **English** and to follow [**the
Conventional Commits
specification**](https://www.conventionalcommits.org/en/v1.0.0/).
- [x] I [added the
**changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)
about the changes that needed to be released. (or didn't have to)
- [x] I wrote or updated **documentation** related to the changes. (or
didn't have to)
- [x] I wrote or updated **tests** related to the changes. (or didn't
have to)
- [x] I tested the changes in various browsers. (or didn't have to)
  - Windows: Chrome, Edge, (Optional) Firefox
  - macOS: Chrome, Edge, Safari, (Optional) Firefox

## Summary
<!-- Please brief explanation of the changes made -->

지원중지된 `LegacySegementedControl` 컴포넌트를 제거합니다. 해당 컴포넌트에만 사용하고 있던 타입 및 유틸
함수를 함께 제거합니다.

## Details
<!-- Please elaborate description of the changes -->

- 채널 데스크 기준 사용처가 없으며, `SegmentedControl` 컴포넌트가 상위 호환으로서 완벽하게 대체가 가능한
컴포넌트이기때문에 제거합니다.
- 해당 컴포넌트에서 사용하고 있었던 타입 및 유틸 함수를 제거합니다. `ProgressBar` 에서 사용중이던 유틸은 적절한
다른 유틸 함수로 변경했습니다. 기존 동작과 100% 동일하지 않을 수 있으나, 문제 없을 것으로 판단됩니다.


### Breaking change? (Yes/No)
<!-- If Yes, please describe the impact and migration path for users -->

Yes. Changeset에 명시해두었습니다.

## References
<!-- Please list any other resources or points the reviewer should be
aware of -->

- #1578 (Remove some deprecated components)
  • Loading branch information
sungik-choi authored Dec 13, 2023
1 parent 8cdbc47 commit 027234f
Show file tree
Hide file tree
Showing 17 changed files with 582 additions and 1,585 deletions.
5 changes: 5 additions & 0 deletions .changeset/short-rice-press.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@channel.io/bezier-react": major
---

Removed `LegacySegmentedControl` component. Previously deprecated in next-v1.204. This component was removed for reasons of web accessibility, keyboard navigation, and design modernization. Use `SegmentedControl` instead.
2 changes: 0 additions & 2 deletions packages/bezier-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
"@rollup/plugin-babel": "^6.0.3",
"@rollup/plugin-commonjs": "^25.0.4",
"@rollup/plugin-node-resolve": "^15.2.1",
"@rollup/plugin-typescript": "^11.1.3",
"@rollup/plugin-url": "^8.0.1",
"@storybook/addon-a11y": "^7.4.2",
"@storybook/addon-actions": "^7.4.2",
Expand Down Expand Up @@ -148,7 +147,6 @@
"@radix-ui/react-tooltip": "^1.0.6",
"@radix-ui/react-visually-hidden": "^1.0.3",
"classnames": "^2.3.2",
"react-resize-detector": "^9.1.0",
"react-textarea-autosize": "8.3.4",
"ssr-window": "^4.0.2",
"uuid": "^9.0.0"
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit 027234f

Please sign in to comment.