You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Looking into Ringbuffer.inl I noticed that Ringbuffer::resize() simply resizes the internal buffer without any additional checks concerning head and tails. Resizing, especially shrinking a Ringbuffer after it was already used can have results ranging from loss or duplication of entries to crashes due to runtime errors. In short, shrinking a buffer such that the head or the tails are left at invalid (too high) indices should be avoided.
Currently, the RingBuffer is used for logging in glbinding-aux, and resizing this buffer is exposed in logging.h.
The text was updated successfully, but these errors were encountered:
Looking into
Ringbuffer.inl
I noticed that Ringbuffer::resize() simply resizes the internal buffer without any additional checks concerning head and tails. Resizing, especially shrinking a Ringbuffer after it was already used can have results ranging from loss or duplication of entries to crashes due to runtime errors. In short, shrinking a buffer such that the head or the tails are left at invalid (too high) indices should be avoided.Currently, the RingBuffer is used for logging in glbinding-aux, and resizing this buffer is exposed in
logging.h
.The text was updated successfully, but these errors were encountered: