Consolidate template breadcrumbs #8233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chosak
reviewed
Mar 15, 2024
| {{ breadcrumbs.render(breadcrumb_items) }} | ||
| </div> | ||
| {% endif %} | ||
| {% include '_breadcrumbs.html' %} |
There was a problem hiding this comment.
Could I please request that we use the "absolute" path to this ('v1/layouts/_breadcrumbs.html') instead of the relative one (here, and in the other instance below)? See comment here for rationale -- loading via relative paths is something bespoke to cf.gov which ideally we could deprecate someday.
There was a problem hiding this comment.
Ah yes, that also makes it consistent with the full layout that was already using the absolute path. Done in eb583e0
willbarton
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the breadcrumbs had inconsistent conditional logic, and in the case of the layout-2-1 template, had the breadcrumb_items definition twice(!)
Changes
_breadcrumbs.htmlinclude.How to test this PR
Form explainer pages
http://localhost:8000/owning-a-home/loan-estimate/
iRegs
http://localhost:8000/rules-policy/regulations/1002/
FIG
http://localhost:8000/data-research/small-business-lending/filing-instructions-guide/2024-guide/
layout 2-1
http://localhost:8000/ask-cfpb/search/?q=mortage
layout 3-1
http://localhost:8000/consumer-tools/educator-tools/financial-well-being-resources/measure-and-score/