-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Less color variables to CSS custom properties (variables) #8171
Conversation
e28bf4d
to
e92c400
Compare
2579dfa
to
527fe94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also take the @
s out of the colorMap in js/routes/on-demand/simple-chart/common-styles.js
(it doesn't matter for functionality, just consistency).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth just fully updating the custom styles in apps/form-explainer/css/form-explainer.less
, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this, just two little nits.
One caveat with the CSS variables is the Less utilities don't recognize them. So a utility like I've updated the JS and code comment names to be in CSS variable style in 2736de2 |
Changes
How to test this PR
yarn install && yarn build
and the site should be unchanged.