ENT-12151: Added possibility to configure Mission Portal web server ports #2947

aleksandrychev · 2024-08-29T11:44:32Z

nickanderson

I approve, but there is a suggestion of order change I think you should accept.

cfe_internal/enterprise/CFE_hub_specific.cf

craigcomstock

yeah, distributed cleanup is the only thing that would have trouble if a feeder uses a different port and there isn't any way to know if THAT feeder over there, from the superhub perspective, has changed it's port or not.

I suppose we would have to include the port number in the information we keep on the superhub about the feeder.

As for the superhub accessing itself, that would need to be adjusted as well.

https://github.com/cfengine/masterfiles/blob/master/templates/federated_reporting/nova_api.py#L99

    def _request(self, method, path, body=None):
        url = "https://{}/api/{}".format(self._hostname, path)

aleksandrychev · 2024-09-05T12:14:11Z

@craigcomstock I adjusted distributed_cleanup.py please review

craigcomstock

I'd say this second commit can be removed.

templates/federated_reporting/distributed_cleanup.py.mustache

craigcomstock

seems pretty solid. I did the httpd.conf changes manually in the template myself in the case of running a VM so I can have multiple VM Hubs, aka port 8008 for rhel-8, 8016 for ubuntu-16, etc. Worked fine so I know the template portion is correct.

aleksandrychev · 2024-09-09T11:34:11Z

aleksandrychev · 2024-09-11T10:21:24Z

@cf-bottom jenkins

cf-bottom · 2024-09-11T10:23:55Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11201/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11201/

aleksandrychev · 2024-09-18T07:40:54Z

@cf-bottom jenkins

cf-bottom · 2024-09-18T07:44:05Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11219/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11219/

craigcomstock · 2024-09-18T14:09:31Z

right, looks like upgrade deployment tests fail with policy related to this change right?

52.18.130.203	   error: Promised replacement "    $config["cli_rest_server_url"] = "https://localhost:443/api/";" for pattern "^\s*\$config\["cli_rest_server_url"\]\s*=\s*"https://localhost.*/api/";\s*$" is not properly convergent while editing "/var/cfengine/share/GUI/application/config/config.php" (pattern still matches the end-state replacement string "    $config["cli_rest_server_url"] = "https://localhost:443/api/";", consider use of a negative look ahead)
52.18.130.203	   error: Errors encountered when actuating replace_patterns promise "^\s*\$config\["cli_rest_server_url"\]\s*=\s*"https://localhost.*/api/";\s*$"

craigcomstock

looks like the policy might need some fixing for upgrade deployment tests in sequential-tests job.

aleksandrychev · 2024-10-07T15:23:50Z

@cf-bottom jenkins

cf-bottom · 2024-10-07T15:24:02Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11239/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11239/

aleksandrychev · 2024-10-07T15:24:59Z

looks like the policy might need some fixing for upgrade deployment tests in sequential-tests job.

yes, trying config changing only if the port is changed. should help 🤞

Ticket: ENT-12151 Signed-off-by: Ihor Aleksandrychiev <[email protected]>

aleksandrychev · 2024-10-08T08:32:23Z

@cf-bottom jenkins

cf-bottom · 2024-10-08T08:34:17Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11243/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11243/

aleksandrychev · 2024-10-08T15:29:52Z

@cf-bottom jenkins

cf-bottom · 2024-10-08T15:34:33Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11247/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11247/

aleksandrychev · 2024-10-10T07:45:11Z

@cf-bottom jenkins

cf-bottom · 2024-10-10T07:48:42Z

Alright, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11256/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11256/

aleksandrychev · 2024-10-11T07:05:16Z

sequential-tests tests failed, I guess is not related

Errors when installing master version HUB packages:
+ grep -P "(err|fail)" .27351.install.log.filtered
52.214.238.164	check for "/var/cfengine/bin/psql" failed: cannot execute
34.244.0.54	check for "/var/cfengine/bin/psql" failed: cannot execute
34.249.48.171	check for "/var/cfengine/bin/psql" failed: cannot execute
54.75.79.92	check for "/var/cfengine/bin/psql" failed: cannot execute

restarted it

craigcomstock · 2024-10-11T15:17:30Z

sequential-tests tests failed, I guess is not related

Errors when installing master version HUB packages:
+ grep -P "(err|fail)" .27351.install.log.filtered
52.214.238.164	check for "/var/cfengine/bin/psql" failed: cannot execute
34.244.0.54	check for "/var/cfengine/bin/psql" failed: cannot execute
34.249.48.171	check for "/var/cfengine/bin/psql" failed: cannot execute
54.75.79.92	check for "/var/cfengine/bin/psql" failed: cannot execute

restarted it

Correct, this is a known issue. https://northerntech.atlassian.net/browse/ENT-12383

It isn't a flake so a restart/retry won't help. We/I will fix soon.

aleksandrychev · 2024-10-14T08:31:42Z

sequential-tests tests failed, I guess is not related
Errors when installing master version HUB packages:
+ grep -P "(err|fail)" .27351.install.log.filtered
52.214.238.164	check for "/var/cfengine/bin/psql" failed: cannot execute
34.244.0.54	check for "/var/cfengine/bin/psql" failed: cannot execute
34.249.48.171	check for "/var/cfengine/bin/psql" failed: cannot execute
54.75.79.92	check for "/var/cfengine/bin/psql" failed: cannot execute
restarted it
Correct, this is a known issue. https://northerntech.atlassian.net/browse/ENT-12383

It isn't a flake so a restart/retry won't help. We/I will fix soon.

thanks! I will wait then

aleksandrychev · 2024-10-17T10:36:08Z

@cf-bottom jenkins

cf-bottom · 2024-10-17T10:39:02Z

Sure, I triggered a build:

Jenkins: https://ci.cfengine.com/job/pr-pipeline/11301/

Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-11301/

aleksandrychev · 2024-10-18T10:45:30Z

@nickanderson @craigcomstock now, when tests are passed, please re-review the code. thanks!

nickanderson

None of my comments are blocking, but I did not actively test the policy does what is expected, just read through it logically.

cfe_internal/enterprise/CFE_hub_specific.cf

cfe_internal/enterprise/mission_portal.cf

nickanderson · 2024-10-24T13:50:04Z

looks like the policy might need some fixing for upgrade deployment tests in sequential-tests job.

@craigcomstock can you please re-review?

craigcomstock

Yeah, one more question about share vs. live, maybe de-dupe that.

CI looks good now that upgrades are mostly fixed.

cfe_internal/enterprise/CFE_hub_specific.cf

Co-authored-by: Craig Comstock <[email protected]>

aleksandrychev force-pushed the ENT-12151/master branch 2 times, most recently from f1c9e68 to 37ef726 Compare August 29, 2024 11:52

aleksandrychev requested a review from nickanderson August 29, 2024 15:49

aleksandrychev force-pushed the ENT-12151/master branch from 37ef726 to ee4be82 Compare August 29, 2024 15:51

nickanderson approved these changes Aug 30, 2024

View reviewed changes

cfe_internal/enterprise/CFE_hub_specific.cf Outdated Show resolved Hide resolved

cfe_internal/enterprise/CFE_hub_specific.cf Show resolved Hide resolved

aleksandrychev force-pushed the ENT-12151/master branch from 5ff1f14 to 53ec589 Compare August 31, 2024 08:09

aleksandrychev requested a review from craigcomstock September 4, 2024 13:37

craigcomstock reviewed Sep 4, 2024

View reviewed changes

aleksandrychev requested a review from craigcomstock September 5, 2024 12:13

craigcomstock requested changes Sep 5, 2024

View reviewed changes

templates/federated_reporting/distributed_cleanup.py.mustache Outdated Show resolved Hide resolved

aleksandrychev force-pushed the ENT-12151/master branch from 96b9b0c to 53ec589 Compare September 6, 2024 10:57

craigcomstock approved these changes Sep 6, 2024

View reviewed changes

craigcomstock requested changes Sep 18, 2024

View reviewed changes

aleksandrychev force-pushed the ENT-12151/master branch from 53ec589 to 126bbc0 Compare October 7, 2024 15:23

aleksandrychev force-pushed the ENT-12151/master branch from 126bbc0 to b6c7096 Compare October 8, 2024 08:30

Added possibility to configure Mission Portal web server ports

b91921b

Ticket: ENT-12151 Signed-off-by: Ihor Aleksandrychiev <[email protected]>

aleksandrychev force-pushed the ENT-12151/master branch from b6c7096 to b91921b Compare October 8, 2024 08:31

aleksandrychev requested review from craigcomstock and nickanderson October 18, 2024 10:44

nickanderson approved these changes Oct 18, 2024

View reviewed changes

cfe_internal/enterprise/CFE_hub_specific.cf Show resolved Hide resolved

cfe_internal/enterprise/mission_portal.cf Show resolved Hide resolved

craigcomstock reviewed Oct 24, 2024

View reviewed changes

cfe_internal/enterprise/CFE_hub_specific.cf Show resolved Hide resolved

craigcomstock reviewed Oct 24, 2024

View reviewed changes

cfe_internal/enterprise/CFE_hub_specific.cf Show resolved Hide resolved

Update cfe_internal/enterprise/CFE_hub_specific.cf

58de119

Co-authored-by: Craig Comstock <[email protected]>

craigcomstock approved these changes Oct 28, 2024

View reviewed changes

craigcomstock merged commit bbec246 into cfengine:master Nov 4, 2024
4 checks passed

craigcomstock added the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Nov 4, 2024

aleksandrychev removed the cherry-pick? Fixes which may need to be cherry-picked to LTS branches label Nov 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENT-12151: Added possibility to configure Mission Portal web server ports #2947

ENT-12151: Added possibility to configure Mission Portal web server ports #2947

aleksandrychev commented Aug 29, 2024 •

edited

Loading

nickanderson left a comment

craigcomstock left a comment

aleksandrychev commented Sep 5, 2024

craigcomstock left a comment

craigcomstock left a comment

aleksandrychev commented Sep 9, 2024 •

edited

Loading

aleksandrychev commented Sep 11, 2024

cf-bottom commented Sep 11, 2024

aleksandrychev commented Sep 18, 2024

cf-bottom commented Sep 18, 2024

craigcomstock commented Sep 18, 2024

craigcomstock left a comment

aleksandrychev commented Oct 7, 2024

cf-bottom commented Oct 7, 2024

aleksandrychev commented Oct 7, 2024

aleksandrychev commented Oct 8, 2024

cf-bottom commented Oct 8, 2024

aleksandrychev commented Oct 8, 2024

cf-bottom commented Oct 8, 2024

aleksandrychev commented Oct 10, 2024

cf-bottom commented Oct 10, 2024

aleksandrychev commented Oct 11, 2024 •

edited

Loading

craigcomstock commented Oct 11, 2024 •

edited

Loading

aleksandrychev commented Oct 14, 2024

aleksandrychev commented Oct 17, 2024

cf-bottom commented Oct 17, 2024

aleksandrychev commented Oct 18, 2024

nickanderson left a comment

nickanderson commented Oct 24, 2024

craigcomstock left a comment

ENT-12151: Added possibility to configure Mission Portal web server ports #2947

ENT-12151: Added possibility to configure Mission Portal web server ports #2947

Conversation

aleksandrychev commented Aug 29, 2024 • edited Loading

nickanderson left a comment

Choose a reason for hiding this comment

craigcomstock left a comment

Choose a reason for hiding this comment

aleksandrychev commented Sep 5, 2024

craigcomstock left a comment

Choose a reason for hiding this comment

craigcomstock left a comment

Choose a reason for hiding this comment

aleksandrychev commented Sep 9, 2024 • edited Loading

aleksandrychev commented Sep 11, 2024

cf-bottom commented Sep 11, 2024

aleksandrychev commented Sep 18, 2024

cf-bottom commented Sep 18, 2024

craigcomstock commented Sep 18, 2024

craigcomstock left a comment

Choose a reason for hiding this comment

aleksandrychev commented Oct 7, 2024

cf-bottom commented Oct 7, 2024

aleksandrychev commented Oct 7, 2024

aleksandrychev commented Oct 8, 2024

cf-bottom commented Oct 8, 2024

aleksandrychev commented Oct 8, 2024

cf-bottom commented Oct 8, 2024

aleksandrychev commented Oct 10, 2024

cf-bottom commented Oct 10, 2024

aleksandrychev commented Oct 11, 2024 • edited Loading

craigcomstock commented Oct 11, 2024 • edited Loading

aleksandrychev commented Oct 14, 2024

aleksandrychev commented Oct 17, 2024

cf-bottom commented Oct 17, 2024

aleksandrychev commented Oct 18, 2024

nickanderson left a comment

Choose a reason for hiding this comment

nickanderson commented Oct 24, 2024

craigcomstock left a comment

Choose a reason for hiding this comment

aleksandrychev commented Aug 29, 2024 •

edited

Loading

aleksandrychev commented Sep 9, 2024 •

edited

Loading

aleksandrychev commented Oct 11, 2024 •

edited

Loading

craigcomstock commented Oct 11, 2024 •

edited

Loading