Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Access Tab in tile configuration is automatically created #292

Open
shahramk opened this issue Jan 3, 2019 · 2 comments
Open

Global Access Tab in tile configuration is automatically created #292

shahramk opened this issue Jan 3, 2019 · 2 comments

Comments

@shahramk
Copy link

shahramk commented Jan 3, 2019

Hello,

I added "enable_global_access_to_plans" flag to my service broker, and it created a separate tab in tile configuration for "Global Access". Is there a way I can get rid of the tab altogether and enable/disable the flag elsewhere?

thank you

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@shahramk
Copy link
Author

shahramk commented Jan 3, 2019

the reason I was thinking of getting rid of the 'Global Access' tab, and enabling/disabling the flag myself is because if you originally set the flag to true, and at a later time decide to set it to false, it doesn't reset the 'service-access'.

After delving further into the deploy-all.erb code here is the code snippet in register_broker:

	if is_true "$GLOBAL_ACCESS"; then
		publicize_services "$BROKER_NAME" "$BROKER_SERVICES"
	fi

In a situation where initially the global access flag is set to true, it sets the service-access to all for all plans. then if later you set the flag to false and re-apply changes, the logic in the code does not reset the service-access, and it always stays as 'all'.

Suggestion: if the service-access is set to false, then reset service-access to 'none' for all plans.

Of course this can be handled in post_deploy module, but if in the first place it is reset either in register_broker or publicize_services methods, it would be more convenient.

thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants