-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LAMMPS_jll doesn't have MPI support #59
Comments
I don't know why the API call doesn't say that we don't have MPI support. But the Yggdrasil build ought to have it: https://github.com/JuliaPackaging/Yggdrasil/blob/3c457abd9bb07c3a769dc5f617b97cf4d1ba5ad5/L/LAMMPS/build_tarballs.jl#L80 We have a minimal test for MPI support here Line 296 in e92fbc8
|
Probably https://github.com/JuliaPackaging/Yggdrasil/blob/3c457abd9bb07c3a769dc5f617b97cf4d1ba5ad5/L/LAMMPS/build_tarballs.jl#L42 needs to be BUILD_MPI |
The test passes even if our LAMMPS binary doesn't have MPI support as it then uses MPI STUBS to pretend to have MPI. In the end the test just starts two independent lammps instances that can't communicate with each other. maybe we should add @test LAMMPS.API.lammps_config_has_mpi_support() != 0 to our tests |
@vchuravy I've noticed that the LAMMPS binaries we provide don't have MPI enabled.
This can be tested with
API.lammps_config_has_mpi_support()
Should we enable MPI support or is there a reason why this is disabled?
The text was updated successfully, but these errors were encountered: